uschindler commented on PR #13636: URL: https://github.com/apache/lucene/pull/13636#issuecomment-2275500767
As discussed before: I'd move all static constants to a package-private class, so it is initialized a bit delayed and not in class loading of VectorizationProvider. To help with @rmuir's fast integer vectors issues: Once this is merged, I plan to split the VectorUtilSupport into ByteVectorUtilSupport and FloatVectorUtilSupport and use 2 getters in VectorizationProvider. By that all the if/else logic is moved to the VectorizationProvider class and we don't need if/else logic in the implementation. Like in Adrien's actual code, the getter for the ByteVectorUtilSupport instance just returns the default one when integer vectors are slow. The checks for this could then all also be outside of static initializers, as they are no longer on hot paths. This can be done separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
