jainankitk commented on PR #13599:
URL: https://github.com/apache/lucene/pull/13599#issuecomment-2253092184
> what do you think of my comment above, would you agree that this change
makes the matches method more expensive?
Probably. I have tweaked the code to avoid the below check. Let me know if
you still feel it becomes expensive.
```
crosses |=
comparator.compare(minPackedValue, offset, lowerPoint, offset)
< 0
|| comparator.compare(maxPackedValue, offset, upperPoint,
offset) > 0;
```
> I think what you propose is anti-pattern for the IntersectsVisitor API.
The point of having two methods is that computing relates is in general more
expensive than compute matches and therefore matches should never call relates.
IMHO, relates and matches can be same method given we don't resolve the
relation further when it intersects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
