iverase commented on PR #13599:
URL: https://github.com/apache/lucene/pull/13599#issuecomment-2247049079
If we look at the current implementation of matches and relates, they both
iterate over the dimensions and they both check if the dimension is disjoint.
If that is true, then they bail out. The difference is when the dimensions are
not disjoint because the relate method executes another check to compute if the
dimensions crosses or is fully inside the range:
```
crosses |=
comparator.compare(minPackedValue, offset, lowerPoint, offset)
< 0
|| comparator.compare(maxPackedValue, offset, upperPoint,
offset) > 0;
```
This is the extra check your change is adding which IMHO is not a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
