jainankitk commented on PR #13599: URL: https://github.com/apache/lucene/pull/13599#issuecomment-2274473157
> I think it's a little clunky for the reader at the same time (it's a bit strange to have to pass the same packed value point twice Thanks @gsmiller for providing this feedback. It also seemed bit odd to be passing same packed value point twice, but still wanted to get opinion on it. After removing the clunky parts, very small change remaining that probably makes sense. Would have liked to not make the change at 2 places, but it seems there is no good way. Just for context, I came across this code path while reviewing the changes for [ApproximateRangeQuery in Opensearch](https://github.com/opensearch-project/OpenSearch/pull/13788). I am wondering if we can make some other changes in `PointRangeQuery` for not having to duplicate lot of code for `ApproximateRangeQuery`. For example - make the anonymous `ConstantScoreWeight` class in the `createWeight` method to named one allowing `ApproximateRangeQuery` to only override the specific methods -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
