gsmiller commented on PR #13599: URL: https://github.com/apache/lucene/pull/13599#issuecomment-2272107532
In general, I really appreciate that you're looking for opportunities to cleanup the codebase and find ways to avoid duplicated logic. Thanks @jainankitk ! At the same time, I don't personally agree with making this change. I do like that you've found a way to avoid the unnecessary work (nice improvement from the original approach that fully delegated to `#relate`), but I'm not sure this change actually solves a meaningful problem and I think it's a little clunky for the reader at the same time (it's a bit strange to have to pass the same packed value point twice, trying to make the abstraction for relating two ranges work with a point). If this logic was used in a lot of places and was a bit more involved, I might be convinced. But as it is, I'm not personally in favor of moving forward with this tweak. That's my opinion at least. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
