benwtrent commented on code in PR #13469:
URL: https://github.com/apache/lucene/pull/13469#discussion_r1633387782
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99ScalarQuantizedVectorsReader.java:
##########
@@ -189,6 +191,18 @@ public ByteVectorValues getByteVectorValues(String field)
throws IOException {
return rawVectorsReader.getByteVectorValues(field);
}
+ @Override
Review Comment:
> The knn queries should automatically do the correct things (e.g. not
eagerly rewrite themselves, etc.)
I am not sure how to do this other than having something that says "Supports
approximate search" to the leaf readers. Or a `try{}catch()` in the query, but
then we are using exceptions as a query flow, which seems trappy and bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
