navneet1v commented on code in PR #13469:
URL: https://github.com/apache/lucene/pull/13469#discussion_r1635173335
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99FlatVectorsReader.java:
##########
@@ -217,6 +220,18 @@ public ByteVectorValues getByteVectorValues(String field)
throws IOException {
vectorData);
}
+ @Override
+ public void search(String field, float[] target, KnnCollector knnCollector,
Bits acceptDocs) throws IOException {
Review Comment:
> @msokolov I suppose that is ok for folks that understand the depths of
codec formats. But we are seriously complicating somebody's life that wants to
use kNN and scalar quantized flat codec. Now they cannot use the knn query, but
instead have to use some specialized query they come up with themselves.
+1 on this comment.
> I think we at least should have a "flat vector query"? or something?
Something that always does exact search so that typical users don't have to do
this iterating & casting stuff?
Rather than having a new query can we just reuse the old query where for a
field we get the right KNNVectorsReader and hit the search interface of the
reader that does the exact search or HNSW based search based on whatever
implementation the KNNVectorsReader have used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
