msokolov commented on code in PR #13469:
URL: https://github.com/apache/lucene/pull/13469#discussion_r1635215676
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99FlatVectorsReader.java:
##########
@@ -217,6 +220,18 @@ public ByteVectorValues getByteVectorValues(String field)
throws IOException {
vectorData);
}
+ @Override
+ public void search(String field, float[] target, KnnCollector knnCollector,
Bits acceptDocs) throws IOException {
Review Comment:
I hear you all, this seems a little weird. One thing is ... you cannot get
access to this stuff at all unless you are willing to create a custom Codec. So
by definition we have weeded out people who don't want to mess around with
Codecs. Another thing is ... we don't really want to create a trap for people
who are trying to find top N vector-distance documents matching some
constraint. They might think by blindly following the API trail/trap that they
should create a BitSet representing their constraint and pass that in to a
Knn*VectorQuery? When instead they would be better off executing their
constraint as the primary Query and using the VectorValues API to do the
scoring. I'm struggling to see the use case for this brute-force query; it just
seems like a trap to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
