msokolov commented on code in PR #13469:
URL: https://github.com/apache/lucene/pull/13469#discussion_r1638780434
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99FlatVectorsFormat.java:
##########
@@ -79,7 +79,8 @@ public final class Lucene99FlatVectorsFormat extends
FlatVectorsFormat {
private final FlatVectorsScorer vectorsScorer;
/** Constructs a format */
- public Lucene99FlatVectorsFormat(FlatVectorsScorer vectorsScorer) {
+ public Lucene99FlatVectorsFormat(String name, FlatVectorsScorer
vectorsScorer) {
+ super(name);
Review Comment:
Makes sense. TBH I kind of just filled out the blanks with this one without
thinking much about it, but I agree the name is really only useful for the SPI
interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
