msokolov commented on code in PR #13469:
URL: https://github.com/apache/lucene/pull/13469#discussion_r1638786155
##########
lucene/codecs/src/java/org/apache/lucene/codecs/bitvectors/HnswBitVectorsFormat.java:
##########
@@ -128,7 +129,7 @@ public HnswBitVectorsFormat(
} else {
this.mergeExec = null;
}
- this.flatVectorsFormat = new Lucene99FlatVectorsFormat(new
FlatBitVectorsScorer());
+ this.flatVectorsFormat = new Lucene99FlatVectorsFormat(NAME_FLAT, new
FlatBitVectorsScorer());
Review Comment:
on the subject of the brute-force query I started to look at adding one and
found we already have
`o.a.l.queries.function.valuesource.VectorSimilarityFunction` -- I think maybe
all we need here is a static convenience method that produces a `FunctionQuery`
wrapping one of these things although I'll confess I'm not entirely conversant
with this API. It seems like it might want to be rewritten in terms of
`VectorScorer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
