easyice commented on code in PR #12841:
URL: https://github.com/apache/lucene/pull/12841#discussion_r1421459009
##########
lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/GroupVIntBenchmark.java:
##########
@@ -140,10 +155,12 @@ public void init() throws Exception {
}
initByteBufferInput(docs);
initArrayInput(docs);
+ initNioInput(docs);
+ initByteBuffersInput(docs);
}
@Benchmark
- public void byteBufferReadVInt(Blackhole bh) throws IOException {
+ public void mmap_byteBufferReadVInt(Blackhole bh) throws IOException {
Review Comment:
> I would rename all those benchmark methods to have better names including
the exact implementation's class name.
How about benchmark methods names like the following?
```
benchMMapDirectoryInputs_readVInt
benchMMapDirectoryInputs_readGroupVInt
benchNIOFSDirectoryInputs_readVInt
benchNIOFSDirectoryInputs_readGroupVInt
benchByteBuffersIndexInput_readVInt
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
