dantuzi commented on PR #12169: URL: https://github.com/apache/lucene/pull/12169#issuecomment-1467824945
@rmuir we spent some time analyzing the code after your comments. #### Index Time At index time the BoostAttribute is ignored as you said but, it looks like we "waste" 4 bytes to store a float and an assignment for each term #### Query Time At query time, everything works as expected because in this [PR](https://github.com/apache/lucene-solr/pull/357/files), @alessandrobenedetti, @dsmiley, and @romseygeek agreed to use BoostAttribute as a container for a float boost to be used at query time. That being said, independently of the Javadoc (that doesn't really explain why a public class can not be used), is there any concrete issue with using the BoostAttribute? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
