[GitHub] [lucene] nknize commented on a diff in pull request #809: LUCENE-10514: Component2D#Within methods should return NOTWITHIN when the query geometry contains the triangle

Wed, 20 Apr 2022 07:19:59 -0700 


nknize commented on code in PR #809:
URL: https://github.com/apache/lucene/pull/809#discussion_r854196239


##########
lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java:
##########
@@ -257,10 +257,13 @@ public WithinRelation withinLine(
       boolean ab,
       double bX,
       double bY) {
-    if (ab == true

Review Comment:
   > Yes, GeometryCollection / MultiPolygon, etc...
   
   
   
   We shouldn't have a problem with MultiPolygon since `The interiors of 2 
Polygons that are elements of a MultiPolygon may not intersect.` ([OGC, Simple 
Features Specification 1.1](https://portal.ogc.org/files/?artifact_id=829)) So 
I think this should only be a valid concern for GeometryCollection?
   
   
![image](https://user-images.githubusercontent.com/830187/164251524-fc4eeb7b-f2d8-4590-814d-afeca7585747.png)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to