iverase commented on code in PR #809:
URL: https://github.com/apache/lucene/pull/809#discussion_r850084313
##########
lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java:
##########
@@ -257,10 +257,13 @@ public WithinRelation withinLine(
boolean ab,
double bX,
double bY) {
- if (ab == true
Review Comment:
That's the point of this issue. We need to care because we need to
distinguish between triangles that are fully inside the query geometry as those
ones needs to be reported as not within. Therefore we need to check if any of
the points is inside.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]