nknize commented on code in PR #809:
URL: https://github.com/apache/lucene/pull/809#discussion_r854258259
##########
lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java:
##########
@@ -257,10 +257,13 @@ public WithinRelation withinLine(
boolean ab,
double bX,
double bY) {
- if (ab == true
Review Comment:
> Yes, but we do no checks
I agree and I don't mean to suggest we throw all sorts of OGC validation
here either. It's just something I think we should take note of for strict OGC
use cases should the question arise. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
