nknize commented on code in PR #809:
URL: https://github.com/apache/lucene/pull/809#discussion_r850671907
##########
lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java:
##########
@@ -257,10 +257,13 @@ public WithinRelation withinLine(
boolean ab,
double bX,
double bY) {
- if (ab == true
Review Comment:
I follow what you're saying wrt the title of the PR. I think I'm having
trouble following the commit message and it might just need to be clearer?
```
1. WE currently might return disjoint when a query geometry fully contains a
triangle / line / point.
2. This causes issues as when an inner node is fully contained in the query
shape, we marked those documents as NOTWITHIN.
3. This PR brings these behaviour together by making sure we always return
NOTWITHIN for fully contained triangles.
```
Wrt 2: inner nodes are driven by the bbox dimensions so why are we caring
about the tessellated trianges for this case? If the bbox falls within the
query geometry its children should be accepted for `INTERSECTS` and `WITHIN`
but rejected for `CONTAINS` and `DISJOINT`. I think the tessellations start to
matter when traversing the leaf nodes? In that case a document should be
collected if a triangle edge is contained by the query geometry in a `WITHIN`
`INTERSECTS` but rejected in a `CONTAINS` and `DISJOINT`.
Can we maybe update the description to more clearly identify what failing
query relations are being fixed by the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
