nknize commented on code in PR #809:
URL: https://github.com/apache/lucene/pull/809#discussion_r850050047
##########
lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java:
##########
@@ -257,10 +257,13 @@ public WithinRelation withinLine(
boolean ab,
double bX,
double bY) {
- if (ab == true
Review Comment:
Something feels off about this though (albeit, it's been a while since I
touched this part of the code), `ab` is intended to identify an edge shared
with the "original" geometry. We shouldn't care about the relation of the
Polygon2D object to tessellation edges when computing a within relation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
