mayya-sharipova edited a comment on pull request #416:
URL: https://github.com/apache/lucene/pull/416#issuecomment-972170715


   @jtibshirani Thanks for your extensive review. I've tried to address some 
comments, and some comments I think we still need to discuss
   
   > does it have an impact on indexing speed?
   
   I've run another benchmarking experiment with `KnnGraphTester` , and as can 
be seen below there seems to be a small impact on indexing speed:  6% increase 
in indexing time;.
   
   #### Comparison of glove-100
   
   baseline: main branch
   candidate: this PR
   
   | Baseline                                                     | candidate   
                                                 |
   | ------------------------------------------------------------ | 
------------------------------------------------------------ |
   | built 1180000 in 23061/2280885 ms                            | built 
1180000 in 23113/2295566 ms                            |
   | flushed: segment=_1 ramUsed=474.061 MB newFlushedSize=513.284 MB 
docs/MB=2,305.768 | flushed: segment=_0 ramUsed=474.061 MB 
newFlushedSize=517.153 MB docs/MB=2,288.517 |
   
   
   
   |             | baseline recall | baseline QPS | candidate recall | 
candidate QPS |
   | ----------- | --------------: | -----------: | ---------------: | 
------------: |
   | n_cands=10  |           0.482 |     4199.190 |            0.496 |      
3982.133 |
   | n_cands=20  |           0.553 |     3563.974 |            0.561 |      
3412.251 |
   | n_cands=40  |           0.631 |     2713.881 |            0.635 |      
2455.465 |
   | n_cands=80  |           0.707 |     1902.787 |            0.709 |      
1863.012 |
   | n_cands=120 |           0.748 |     1497.979 |            0.747 |      
1400.822 |
   | n_cands=200 |           0.790 |     1031.353 |            0.791 |      
1018.244 |
   | n_cands=400 |           0.840 |      577.106 |            0.841 |       
600.762 |
   | n_cands=600 |           0.865 |      417.961 |            0.865 |       
436.488 |
   | n_cands=800 |           0.881 |      319.900 |            0.881 |       
334.503 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to