mayya-sharipova commented on a change in pull request #416:
URL: https://github.com/apache/lucene/pull/416#discussion_r769229827
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java
##########
@@ -205,6 +215,43 @@ private FieldEntry readField(DataInput input) throws
IOException {
return new FieldEntry(input, similarityFunction);
}
+ private void fillGraphNodesAndOffsetsByLevel() throws IOException {
+ for (FieldEntry entry : fields.values()) {
+ IndexInput input =
Review comment:
> How would you like to proceed -- work on that PR first (since it seems
useful on its own), or move forward with this one and follow-up with a fix soon
after?
I was under the impression that we are not happy with the current state of
this PR and would not want to merge it without some changes. No?
> To clarify, I was not thinking that GraphLevels would replace FieldEntry.
It would be a second data structure.
Can you please elaborate more how to do you see it is organized? How
`GraphLevels` connected to a `FieldEntry`? Do you suggest put GraphLevels into
a separate file and load them on a first use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
