mayya-sharipova commented on a change in pull request #416:
URL: https://github.com/apache/lucene/pull/416#discussion_r767385760
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java
##########
@@ -205,6 +215,43 @@ private FieldEntry readField(DataInput input) throws
IOException {
return new FieldEntry(input, similarityFunction);
}
+ private void fillGraphNodesAndOffsetsByLevel() throws IOException {
+ for (FieldEntry entry : fields.values()) {
+ IndexInput input =
Review comment:
@jtibshirani
> It feels a bit surprising that FieldEntry is constructed across two
different files (both the metadata and graph index files)
As an alternative, to make FieldEntry fields only from a single `meta` file,
I've created a [PR](https://github.com/apache/lucene/pull/536) that keeps the
current 3 files ( .vec, .vex, and .vem), where .vem file stores all the
level's nodes; but instead of storing neighbour's offsets we calculate them,
which allows to keep .vem metadata file smaller. What do you think of this
approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
