dweiss commented on a change in pull request #2313:
URL: https://github.com/apache/lucene-solr/pull/2313#discussion_r571663026
##########
File path:
lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestPerformance.java
##########
@@ -40,8 +42,15 @@
* en.txt}) in a directory specified in {@code -Dhunspell.corpora=...}
*/
@TestCaseOrdering(TestCaseOrdering.AlphabeticOrder.class)
-@Ignore("enable manually")
Review comment:
Not if you create a launch config that just has one of those properties
(just the hunspell.dictionaries) - then perf tests would be skipped. If you
launch everything from the same launcher then indeed this will be a problem. I
don't care much but it'd be my preference to control it somehow without
modifying the code itself. You could use a custom property, test group
annotation... whatever works. I think two properties already separate these
tests well enough though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
