donnerpeter commented on a change in pull request #2313:
URL: https://github.com/apache/lucene-solr/pull/2313#discussion_r571615230
##########
File path:
lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java
##########
@@ -59,42 +67,52 @@ static Dictionary loadDictionary(Path aff) throws
IOException, ParseException {
}
public void testDictionariesLoadSuccessfully() throws Exception {
- int failures = 0;
- for (Path aff : findAllAffixFiles().collect(Collectors.toList())) {
- try {
- System.out.println(aff + "\t" + memoryUsage(loadDictionary(aff)));
- } catch (Throwable e) {
- failures++;
- System.err.println("While checking " + aff + ":");
- e.printStackTrace();
+ int threads = Runtime.getRuntime().availableProcessors();
+ ExecutorService executor = Executors.newFixedThreadPool(threads);
+ try {
+ Deque<Path> failures = new ConcurrentLinkedDeque<>();
Review comment:
`synchronizedList` might look less surprising to readers :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
