dweiss commented on a change in pull request #2313:
URL: https://github.com/apache/lucene-solr/pull/2313#discussion_r571662561
##########
File path:
lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java
##########
@@ -59,42 +67,52 @@ static Dictionary loadDictionary(Path aff) throws
IOException, ParseException {
}
public void testDictionariesLoadSuccessfully() throws Exception {
- int failures = 0;
- for (Path aff : findAllAffixFiles().collect(Collectors.toList())) {
- try {
- System.out.println(aff + "\t" + memoryUsage(loadDictionary(aff)));
- } catch (Throwable e) {
- failures++;
- System.err.println("While checking " + aff + ":");
- e.printStackTrace();
+ int threads = Runtime.getRuntime().availableProcessors();
+ ExecutorService executor = Executors.newFixedThreadPool(threads);
+ try {
+ Deque<Path> failures = new ConcurrentLinkedDeque<>();
+ Function<Path, Void> process =
+ (Path aff) -> {
+ try {
+ System.out.println(aff + "\t" +
memoryUsage(loadDictionary(aff)));
+ } catch (Throwable e) {
+ failures.add(aff);
+ System.err.println("While checking " + aff + ":");
+ e.printStackTrace();
+ }
+ return null;
+ };
+
+ for (Future<?> future :
+ executor.invokeAll(
+ findAllAffixFiles()
+ .map(aff -> (Callable<?>) () -> process.apply(aff))
+ .collect(Collectors.toList()))) {
+ future.get();
+ }
+
+ if (!failures.isEmpty()) {
+ throw new AssertionError(
+ "Certain dictionaries failed to parse:\n - "
+ + failures.stream()
+ .map(path -> path.toAbsolutePath().toString())
+ .collect(Collectors.joining("\n - ")));
}
+ } finally {
+ executor.shutdown();
+ executor.awaitTermination(1, TimeUnit.MINUTES);
}
- assertEquals(failures + " failures!", 0, failures);
}
private static String memoryUsage(Dictionary dic) {
return RamUsageTester.humanSizeOf(dic)
+ "\t("
- + "words="
- + RamUsageTester.humanSizeOf(dic.words)
- + ", "
- + "flags="
- + RamUsageTester.humanSizeOf(dic.flagLookup)
- + ", "
- + "strips="
- + RamUsageTester.humanSizeOf(dic.stripData)
- + ", "
- + "conditions="
- + RamUsageTester.humanSizeOf(dic.patterns)
- + ", "
- + "affixData="
- + RamUsageTester.humanSizeOf(dic.affixData)
- + ", "
- + "prefixes="
- + RamUsageTester.humanSizeOf(dic.prefixes)
- + ", "
- + "suffixes="
- + RamUsageTester.humanSizeOf(dic.suffixes)
- + ")";
+ + ("words=" + RamUsageTester.humanSizeOf(dic.words) + ", ")
Review comment:
Yes, such hints and groupings make logical sense and also help with
formatting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
