dweiss commented on a change in pull request #2313: URL: https://github.com/apache/lucene-solr/pull/2313#discussion_r571662133
########## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java ########## @@ -20,31 +20,39 @@ import java.io.InputStream; import java.nio.file.Files; import java.nio.file.Path; +import java.nio.file.Paths; import java.text.ParseException; +import java.util.Deque; +import java.util.concurrent.Callable; +import java.util.concurrent.ConcurrentLinkedDeque; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.Future; +import java.util.concurrent.TimeUnit; +import java.util.function.Function; import java.util.stream.Collectors; import java.util.stream.Stream; import org.apache.lucene.store.BaseDirectoryWrapper; import org.apache.lucene.util.LuceneTestCase; import org.apache.lucene.util.LuceneTestCase.SuppressSysoutChecks; import org.apache.lucene.util.RamUsageTester; import org.junit.Assume; -import org.junit.Ignore; /** - * Loads all dictionaries from the directory specified in {@code -Dhunspell.dictionaries=...} and - * prints their memory usage. All *.aff files are traversed directly inside the given directory or - * in its immediate subdirectories. Each *.aff file must have a same-named sibling *.dic file. For - * examples of such directories, refer to the {@link org.apache.lucene.analysis.hunspell package - * documentation} + * Loads all dictionaries from the directory specified in {@code hunspell.dictionaries} system + * property and prints their memory usage. All *.aff files are traversed directly inside the given + * directory or in its immediate subdirectories. Each *.aff file must have a same-named sibling Review comment: Yep, thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org