donnerpeter commented on a change in pull request #2313:
URL: https://github.com/apache/lucene-solr/pull/2313#discussion_r571615401
##########
File path:
lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java
##########
@@ -59,42 +67,52 @@ static Dictionary loadDictionary(Path aff) throws
IOException, ParseException {
}
public void testDictionariesLoadSuccessfully() throws Exception {
- int failures = 0;
- for (Path aff : findAllAffixFiles().collect(Collectors.toList())) {
- try {
- System.out.println(aff + "\t" + memoryUsage(loadDictionary(aff)));
- } catch (Throwable e) {
- failures++;
- System.err.println("While checking " + aff + ":");
- e.printStackTrace();
+ int threads = Runtime.getRuntime().availableProcessors();
+ ExecutorService executor = Executors.newFixedThreadPool(threads);
Review comment:
Thanks for parallelization! I've considered it, but never got to do it.
##########
File path:
lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestPerformance.java
##########
@@ -40,8 +42,15 @@
* en.txt}) in a directory specified in {@code -Dhunspell.corpora=...}
*/
@TestCaseOrdering(TestCaseOrdering.AlphabeticOrder.class)
-@Ignore("enable manually")
Review comment:
I actually took advantage of this. Running all tests in a package
skipped the ignored ones, and so the correctness was checked relatively
quickly. Now that'd also include performance/allDict tests, and can become
slower :( But I can work around that locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
