murblanc commented on a change in pull request #2101: URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r535333392
########## File path: solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java ########## @@ -239,8 +238,7 @@ private static String getActualPath(ApiInfo apiInfo, String path) { @SuppressWarnings({"rawtypes", "unchecked"}) private static Map<String, String> getTemplateVars(PluginMeta pluginMeta) { - Map result = makeMap("plugin-name", pluginMeta.name, "path-prefix", pluginMeta.pathPrefix); - return result; + return (Map) makeMap("plugin-name", pluginMeta.name, "path-prefix", pluginMeta.pathPrefix); Review comment: Should replace the call to `makeMap` by `Map.of(...)`. This allows removing the cast and removing the `@SuppressWarnings`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org