murblanc commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r534219720
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -257,6 +260,7 @@ public CoreLoadFailure(CoreDescriptor cd, Exception
loadFailure) {
// initially these are the same to collect the plugin-based listeners during
init
private ClusterEventProducer clusterEventProducer;
+ private PlacementPluginFactory placementPluginFactory;
Review comment:
I believe we have a synchronization issue here on access to that
variable. It is not `final` nor `volatile`, access is not synchronized but it
is accessed from multiple threads (the command execution Overseer threads
calling `getPlacementPluginFactory()`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
