murblanc commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r535361621
##########
File path:
solr/core/src/test/org/apache/solr/cluster/placement/impl/PlacementPluginIntegrationTest.java
##########
@@ -109,4 +132,108 @@ public void testMinimizeCores() throws Exception {
assertEquals("min cores too low", 1, minCores);
}
+ @Test
+ @SuppressWarnings("unchecked")
+ public void testDynamicReconfiguration() throws Exception {
+ PlacementPluginFactory<? extends MapWriter> pluginFactory =
cc.getPlacementPluginFactory();
+ assertTrue("wrong type " + pluginFactory.getClass().getName(),
pluginFactory instanceof DelegatingPlacementPluginFactory);
+ DelegatingPlacementPluginFactory wrapper =
(DelegatingPlacementPluginFactory) pluginFactory;
+
+ int version = wrapper.getVersion();
+ log.debug("--initial version={}", version);
+
+ PluginMeta plugin = new PluginMeta();
+ plugin.name = PlacementPluginFactory.PLUGIN_NAME;
+ plugin.klass = MinimizeCoresPlacementFactory.class.getName();
+ V2Request req = new V2Request.Builder("/cluster/plugin")
+ .forceV2(true)
+ .POST()
+ .withPayload(singletonMap("add", plugin))
+ .build();
+ req.process(cluster.getSolrClient());
+
+ version = waitForVersionChange(version, wrapper, 10);
+
+ assertTrue("wrong version " + version, version > 0);
+ PlacementPluginFactory<? extends MapWriter> factory =
wrapper.getDelegate();
Review comment:
`<? extends PlacementPluginConfig>`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
