murblanc commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r534255115
##########
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/AddReplicaCmd.java
##########
@@ -144,7 +140,8 @@ public void call(ClusterState state, ZkNodeProps message,
@SuppressWarnings({"ra
}
}
- List<CreateReplica> createReplicas =
buildReplicaPositions(ocmh.cloudManager, clusterState, collectionName, message,
replicaTypesVsCount)
+ List<CreateReplica> createReplicas =
buildReplicaPositions(ocmh.cloudManager, clusterState, collectionName, message,
replicaTypesVsCount,
+
ocmh.overseer.getCoreContainer().getPlacementPluginFactory().createPluginInstance())
Review comment:
Unclear to me: what happens here when placement plugins are not
configured and we use for example the legacy assign strategy?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
