murblanc commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r534209824
##########
File path:
solr/core/src/java/org/apache/solr/cluster/placement/PlacementPluginFactory.java
##########
@@ -18,14 +18,22 @@
package org.apache.solr.cluster.placement;
/**
- * Factory implemented by client code and configured in {@code solr.xml}
allowing the creation of instances of
+ * Factory implemented by client code and configured in container plugins
allowing the creation of instances of
* {@link PlacementPlugin} to be used for replica placement computation.
+ * <p>Note: configurable factory implementations should also implement
+ * {@link org.apache.solr.api.ConfigurablePlugin} with the appropriate
configuration
+ * bean type.</p>
*/
public interface PlacementPluginFactory {
Review comment:
Shouldn't this interface extend `ConfigurablePlugin<T extends
MapWriter>` so that concrete config classes such as `AffinityPlacementFactory`
do not have to implement multiple interfaces?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
