gerlowskija commented on a change in pull request #1151: SOLR-13890: Add
"top-level" DVTQ implementation
URL: https://github.com/apache/lucene-solr/pull/1151#discussion_r364215294
##########
File path: solr/core/src/java/org/apache/solr/search/TermsQParserPlugin.java
##########
@@ -138,8 +164,128 @@ public Query parse() throws SyntaxError {
bytesRefs[i] = term.toBytesRef();
}
- return method.makeFilter(fname, bytesRefs);
+ return method.makeFilter(fname, bytesRefs, localParams);
}
};
}
+
+ private static abstract class TopLevelTwoPhaseIterator extends
TwoPhaseIterator {
+ private final int docBase;
+ private final int nextDocBase;
+ public TopLevelTwoPhaseIterator(DocIdSetIterator approximation, int
docBase, int nextDocBase) {
+ super(new PerSegmentViewDocIdSetIterator(approximation, docBase,
nextDocBase));
+
+ this.docBase = docBase;
+ this.nextDocBase = nextDocBase;
+ }
+ }
+
+ private static class TopLevelDocValuesTermsQuery extends DocValuesTermsQuery
implements ExtendedQuery{
Review comment:
Will that work? My understanding was that SolrIndexSearcher uses cost/cache
iff it notices its working with an ExtendedQuery that has `getCost`/`getCache`
methods it can use. (i.e. it uses those specific methods, it doesn't root
around in SolrParams objects looking for cost/cache param values.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
