dsmiley commented on a change in pull request #1151: SOLR-13890: Add
"top-level" DVTQ implementation
URL: https://github.com/apache/lucene-solr/pull/1151#discussion_r363744702
##########
File path: solr/core/src/java/org/apache/solr/search/TermsQParserPlugin.java
##########
@@ -79,20 +88,34 @@ Query makeFilter(String fname, BytesRef[] byteRefs) {
},
automaton {
@Override
- Query makeFilter(String fname, BytesRef[] byteRefs) {
+ Query makeFilter(String fname, BytesRef[] byteRefs, SolrParams
localParams) {
ArrayUtil.timSort(byteRefs); // same sort algo as TermInSetQuery's
choice
Automaton union = Automata.makeStringUnion(Arrays.asList(byteRefs));
// input must be sorted
return new AutomatonQuery(new Term(fname), union);//constant scores
}
},
docValuesTermsFilter {//on 4x this is FieldCacheTermsFilter but we use the
5x name any way
@Override
- Query makeFilter(String fname, BytesRef[] byteRefs) {
- return new DocValuesTermsQuery(fname, byteRefs);//constant scores
+ Query makeFilter(String fname, BytesRef[] byteRefs, SolrParams
localParams) {
+ final String type = localParams.get(SUBMETHOD);
Review comment:
Instead of yet another local-param, maybe "method" could be
docValuesTermsFilterTopLevel and docValuesTermsFilterTopLevel. The existing
docValuesTermsFilter could dispatch to either of those.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
