dsmiley commented on a change in pull request #1151: SOLR-13890: Add "top-level" DVTQ implementation URL: https://github.com/apache/lucene-solr/pull/1151#discussion_r363745450
########## File path: solr/core/src/java/org/apache/solr/search/TermsQParserPlugin.java ########## @@ -138,8 +164,128 @@ public Query parse() throws SyntaxError { bytesRefs[i] = term.toBytesRef(); } - return method.makeFilter(fname, bytesRefs); + return method.makeFilter(fname, bytesRefs, localParams); } }; } + + private static abstract class TopLevelTwoPhaseIterator extends TwoPhaseIterator { Review comment: I don't think you need this class; it seems more confusing than it is useful ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org