dsmiley commented on a change in pull request #1151: SOLR-13890: Add
"top-level" DVTQ implementation
URL: https://github.com/apache/lucene-solr/pull/1151#discussion_r363740102
##########
File path: lucene/core/src/java/org/apache/lucene/search/TwoPhaseIterator.java
##########
@@ -64,7 +64,7 @@ public static TwoPhaseIterator unwrap(DocIdSetIterator
iterator) {
TwoPhaseIteratorAsDocIdSetIterator(TwoPhaseIterator twoPhaseIterator) {
this.twoPhaseIterator = twoPhaseIterator;
- this.approximation = twoPhaseIterator.approximation;
+ this.approximation = twoPhaseIterator.approximation();
Review comment:
Is this just a minor improvement or is it necessary? If just some minor
improvement, I recommend you don't touch Lucene in a Solr PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
