[ 
https://issues.apache.org/jira/browse/SOLR-13661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933791#comment-16933791
 ] 

David Smiley commented on SOLR-13661:
-------------------------------------

All this stuff is exciting and bodes well for Solr's future, particularly if it 
gets to the point of a plugin registry including 3rd party stuff.  Thanks Jan, 
Ishan, and Noble; you have put a lot of time and thought into this.  I'd like 
to help – initially as a reviewer and maybe eventually more.

So what should the relationship be between Jan's SOLR-10665 and this one?  I 
suppose Jan's is focused on being the POC and this issue is about more detailed 
execution?  There is no issue link yet.

I see committed code already from the sub-tasks has been committed to master 
and not 8.3, and thus we won't be shipping WIP stuff – which I'm glad for.  
Doesn't an effort of this magnitude warrant a branch?  It's debatable but as 
long as it's not super long-lived then the merge back is fine.

[~noble.paul] did you forget (again) to resolve the issues you committed or are 
they deliberately open because they haven't landed on 8.x yet?  The "Open" 
status confuses me and it seems like a problem but I could be convinced 
otherwise.

[~noble.paul] There have been no code reviews yet on this committed code; 
right?  I looked and see none but I wasn't exhaustive.  I know you work with 
Ishan so I was hoping it's happening here but I don't see it and that concerns 
me (yeah I know it's a challenge for Solr overall).  I will put some time into 
code reviews here too; I hope to contribute the most in this way right now.  
All my code at Salesforce is reviewed; it's a great practice. Be prepared for 
follow-up cleanups on these already committed issues ;)

> A package management system for Solr
> ------------------------------------
>
>                 Key: SOLR-13661
>                 URL: https://issues.apache.org/jira/browse/SOLR-13661
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Noble Paul
>            Priority: Major
>              Labels: package
>
> Solr needs a unified cohesive package management system so that users can 
> deploy/redeploy plugins in a safe manner. This is an umbrella issue to 
> eventually build that solution



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to