cccs-eric commented on code in PR #7921: URL: https://github.com/apache/iceberg/pull/7921#discussion_r1254295336
########## python/tests/catalog/test_jdbc.py: ########## @@ -0,0 +1,36 @@ +import pytest + +from pyiceberg.catalog.jdbc import JDBCCatalog +from pyiceberg.exceptions import NoSuchPropertyException Review Comment: Yes, it was on my todo list. I also argued with Fokko that we should have a suite of integration tests that applies to all pyiceberg catalogs. I ended up copying most of the tests from DynamoDB and Glue with not many changes, so I think it is possible to achieve. This would ensure that all catalogs behave the same (which wasn't the case for Glue, see [issue](https://github.com/apache/iceberg/issues/7935)) and it would make contributing a new catalog that much easier to test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
