rdblue commented on code in PR #7921:
URL: https://github.com/apache/iceberg/pull/7921#discussion_r1252382489
##########
python/pyiceberg/catalog/__init__.py:
##########
@@ -137,6 +145,10 @@ def infer_catalog_type(name: str, catalog_properties:
RecursiveDict) -> Optional
return CatalogType.REST
elif uri.startswith("thrift"):
return CatalogType.HIVE
+ elif uri.startswith("postgresql"):
+ return CatalogType.JDBC
+ elif uri.startswith("file"):
Review Comment:
I'm not sure this makes sense to me. Why would a "file://" catalog URI
signal that a database should be used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
