cccs-eric commented on code in PR #7921:
URL: https://github.com/apache/iceberg/pull/7921#discussion_r1254287410
##########
python/pyiceberg/catalog/__init__.py:
##########
@@ -75,6 +75,7 @@ class CatalogType(Enum):
HIVE = "hive"
GLUE = "glue"
DYNAMODB = "dynamodb"
+ JDBC = "jdbc"
Review Comment:
I felt the same when I wrote this line of code, but wasn't sure if I had the
rights to rebrand this! `sql`, `database`, `rdbms`...? My only concern is
will that be confusing for users using both Java and Pyiceberg? Shouldn't be,
but the components will be named differently between Java and Python. So it's
a question of consistency VS accuracy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
