rdblue commented on code in PR #7921:
URL: https://github.com/apache/iceberg/pull/7921#discussion_r1252382917
##########
python/pyiceberg/catalog/__init__.py:
##########
@@ -75,6 +75,7 @@ class CatalogType(Enum):
HIVE = "hive"
GLUE = "glue"
DYNAMODB = "dynamodb"
+ JDBC = "jdbc"
Review Comment:
Do we want to call this JDBC or do we want to call it just a "database"
catalog? JDBC signals Java to me. I know it's the name we've used in the JVM
implementation, but I think we should consider naming it differently here to
avoid confusion. We probably can't change it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
