rdblue commented on code in PR #7921: URL: https://github.com/apache/iceberg/pull/7921#discussion_r1252385302
########## python/tests/catalog/test_jdbc.py: ########## @@ -0,0 +1,36 @@ +import pytest + +from pyiceberg.catalog.jdbc import JDBCCatalog +from pyiceberg.exceptions import NoSuchPropertyException Review Comment: There are a lot of good tests in Java's `CatalogTests`. It probably makes sense to copy those over here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
