cccs-eric commented on code in PR #7921:
URL: https://github.com/apache/iceberg/pull/7921#discussion_r1254279487
##########
python/pyiceberg/catalog/__init__.py:
##########
@@ -137,6 +145,10 @@ def infer_catalog_type(name: str, catalog_properties:
RecursiveDict) -> Optional
return CatalogType.REST
elif uri.startswith("thrift"):
return CatalogType.HIVE
+ elif uri.startswith("postgresql"):
+ return CatalogType.JDBC
+ elif uri.startswith("file"):
Review Comment:
I'll remove this, it's a left over of when I tried to support both
PostgreSQL and sqlite. I quickly realized that abstracting the database driver
would be more difficult that I thought without relying on a framework like
SQLAlchemy. Not impossible, but maybe a little out of scope for this initial
draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
