rdblue commented on code in PR #6651:
URL: https://github.com/apache/iceberg/pull/6651#discussion_r1101939155
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkDataWrite.java:
##########
@@ -71,9 +72,18 @@ public class TestSparkDataWrite {
@Rule public TemporaryFolder temp = new TemporaryFolder();
- @Parameterized.Parameters(name = "format = {0}")
+ private String targetBranch;
+
+ @Parameterized.Parameters(name = "format = {0}, branch = {1}")
public static Object[] parameters() {
- return new Object[] {"parquet", "avro", "orc"};
+ return new Object[][] {
+ new Object[] {"parquet", "main"},
+ new Object[] {"parquet", "testBranch"},
Review Comment:
We don't need to test all formats and branch/main combinations. We can just
do parquet/main, parquet/testBranch, avro/main, orc/testBranch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
