rdblue commented on code in PR #6651:
URL: https://github.com/apache/iceberg/pull/6651#discussion_r1101940677


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java:
##########
@@ -281,6 +281,12 @@ public boolean canDeleteWhere(Filter[] filters) {
   private boolean canDeleteUsingMetadata(Expression deleteExpr) {
     boolean caseSensitive =
         
Boolean.parseBoolean(sparkSession().conf().get("spark.sql.caseSensitive"));
+
+    String branch =
+        sparkSession().conf().contains(SparkWriteOptions.BRANCH)
+            ? sparkSession().conf().get(SparkWriteOptions.BRANCH)
+            : null;

Review Comment:
   This is another area that should not use a `SparkWriteOption` with session 
conf.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to