rdblue commented on code in PR #6651:
URL: https://github.com/apache/iceberg/pull/6651#discussion_r1101932641
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -304,4 +305,13 @@ public boolean caseSensitive() {
.defaultValue(SQLConf.CASE_SENSITIVE().defaultValueString())
.parse();
}
+
+ public String branch() {
+ return confParser
+ .stringConf()
+ .option(SparkWriteOptions.BRANCH)
+ .sessionConf(SparkWriteOptions.BRANCH)
Review Comment:
Similar to above, I think this should be a `SparkSQLProperties` entry and
should be something like `spark.sql.iceberg.write-branch`. Unlike the read
side, it's correct to return this from `branch()` if it is defined because
branches are automatically created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
