namrathamyske commented on code in PR #6651:
URL: https://github.com/apache/iceberg/pull/6651#discussion_r1103412331


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##########
@@ -83,7 +83,11 @@ public Long endSnapshotId() {
   }
 
   public String branch() {
-    return 
confParser.stringConf().option(SparkReadOptions.BRANCH).parseOptional();
+    return confParser
+        .stringConf()
+        .sessionConf(SparkReadOptions.BRANCH)

Review Comment:
   @rdblue @amogh-jahagirdar  i am going to remove all session related changes 
from this PR so that can raise a follow up one. We can support only write by 
spark option in this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to