jackye1995 commented on code in PR #6651:
URL: https://github.com/apache/iceberg/pull/6651#discussion_r1103834683
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java:
##########
@@ -349,8 +353,7 @@ private OverwriteByFilter(Expression overwriteExpr) {
@Override
public void commit(WriterCommitMessage[] messages) {
- OverwriteFiles overwriteFiles = table.newOverwrite();
- overwriteFiles.overwriteByRowFilter(overwriteExpr);
+ OverwriteFiles overwriteFiles =
table.newOverwrite().overwriteByRowFilter(overwriteExpr);
Review Comment:
this line change is not necessary?
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java:
##########
@@ -349,8 +353,7 @@ private OverwriteByFilter(Expression overwriteExpr) {
@Override
public void commit(WriterCommitMessage[] messages) {
- OverwriteFiles overwriteFiles = table.newOverwrite();
- overwriteFiles.overwriteByRowFilter(overwriteExpr);
+ OverwriteFiles overwriteFiles =
table.newOverwrite().overwriteByRowFilter(overwriteExpr);
Review Comment:
this change is not necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
