rdblue commented on code in PR #6139:
URL: https://github.com/apache/iceberg/pull/6139#discussion_r1027142919
##########
python/pyiceberg/expressions/__init__.py:
##########
@@ -40,36 +59,36 @@ def __invert__(self) -> BooleanExpression:
"""Transform the Expression into its negated version."""
-class Term(Generic[T], ABC):
+class Term(Generic[L], ABC):
"""A simple expression that evaluates to a value"""
class Bound(ABC):
"""Represents a bound value expression"""
-class Unbound(Generic[B], ABC):
+class Unbound(ABC):
"""Represents an unbound value expression"""
+ @property
@abstractmethod
- def bind(self, schema: Schema, case_sensitive: bool = True) -> B:
Review Comment:
Minor: it seems valuable to continue to have a `bind` method on all unbound
things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
