rdblue commented on code in PR #6139:
URL: https://github.com/apache/iceberg/pull/6139#discussion_r1024489449
##########
python/tests/expressions/test_expressions.py:
##########
@@ -254,15 +218,15 @@ def test_empty_bind_not_in(table_schema_simple: Schema):
def test_bind_not_in_equal_term(table_schema_simple: Schema):
bound = BoundNotIn(
- BoundReference(table_schema_simple.find_field(1),
table_schema_simple.accessor_for_field(1)), {literal("hello")}
+ BoundReference[str](table_schema_simple.find_field(1),
table_schema_simple.accessor_for_field(1)), {"hello"}
Review Comment:
I don't think that bound references should allow bare values. This creates
more changes and doesn't seem necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
