rdblue commented on code in PR #6139: URL: https://github.com/apache/iceberg/pull/6139#discussion_r1024487574
########## python/tests/expressions/test_literals.py: ########## @@ -398,8 +397,8 @@ def test_fixed_literal(): def test_binary_literal(): - bin_lit012 = literal(bytearray([0x00, 0x01, 0x02])) - bin_lit013 = literal(bytearray([0x00, 0x01, 0x03])) + bin_lit012 = literal(bytes([0x00, 0x01, 0x02])) + bin_lit013 = literal(bytes([0x00, 0x01, 0x03])) Review Comment: Is this change still needed? I thought that `literal(b: bytearray)` was able to produce `Literal[bytes]`. If that's not the case then this is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
