rdblue commented on code in PR #6139:
URL: https://github.com/apache/iceberg/pull/6139#discussion_r1027144231
##########
python/tests/expressions/test_expressions.py:
##########
@@ -202,48 +178,36 @@ def test_notnan_bind_nonfloat():
assert NotNaN(Reference("i")).bind(schema) == AlwaysTrue()
-@pytest.mark.parametrize(
- "op, string",
- [
- (And(ExpressionA(), ExpressionB()), "And(left=ExpressionA(),
right=ExpressionB())"),
- (Or(ExpressionA(), ExpressionB()), "Or(left=ExpressionA(),
right=ExpressionB())"),
- (Not(ExpressionA()), "Not(child=ExpressionA())"),
- ],
-)
-def test_strs(op, string):
- assert str(op) == string
-
-
def test_ref_binding_case_sensitive(table_schema_simple: Schema):
- ref = Reference[str]("foo")
+ ref = Reference("foo")
bound = BoundReference[str](table_schema_simple.find_field(1),
table_schema_simple.accessor_for_field(1))
assert ref.bind(table_schema_simple, case_sensitive=True) == bound
def test_ref_binding_case_sensitive_failure(table_schema_simple: Schema):
- ref = Reference[str]("Foo")
+ ref = Reference("Foo")
with pytest.raises(ValueError):
ref.bind(table_schema_simple, case_sensitive=True)
def test_ref_binding_case_insensitive(table_schema_simple: Schema):
- ref = Reference[str]("Foo")
+ ref = Reference("Foo")
bound = BoundReference[str](table_schema_simple.find_field(1),
table_schema_simple.accessor_for_field(1))
assert ref.bind(table_schema_simple, case_sensitive=False) == bound
def test_ref_binding_case_insensitive_failure(table_schema_simple: Schema):
- ref = Reference[str]("Foot")
+ ref = Reference("Foot")
with pytest.raises(ValueError):
ref.bind(table_schema_simple, case_sensitive=False)
def test_in_to_eq():
- assert In(Reference("x"), (literal(34.56),)) == EqualTo(Reference("x"),
literal(34.56))
+ assert In("x", (34.56,)) == EqualTo(Reference("x"), 34.56)
Review Comment:
Nit: `Reference` used here still.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
